feature: Use PSR-18 compatible wrapper for Laravel HTTP client #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit nervous that we move our implementation to a 3rd party wrapper package. It seems my argument is more with Laravel on why their HTTP Client isn't PSR-18 compatible. When we saw the last implementation (https://github.com/gehrisandro/laravel-http-psr18) of wrapping Laravel/HTTP it had some issues. I wonder what we are looking at in terms of stability. Is this package basically done forever, barring a major Guzzle change? It seems PSR-18 is set and Guzzle probably isn't changing until a major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to review OpenAI requests using Telescope which captures requests made using the Laravel HTTP Client, however this integration uses Guzzle directly.
The OpenAI PHP library supports any PSR-18 compatible client, so I pulled in
swisnl/laravel-psr-http-client-bridgewhich is a PSR-18 compatible wrapper around the Laravel HTTP Client and used that instead of Guzzle directly.This change allows the requests to show up in Telescope as expected.